Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VirtualQueryEx, MEMORY_BASIC_INFORMATION, and related constants #368

Merged
merged 1 commit into from
Sep 20, 2014

Conversation

apskii
Copy link
Contributor

@apskii apskii commented Sep 19, 2014

@apskii apskii changed the title Add VirtualQueryEx, MEMORY_BASIC_INFORMATION, and related constants Added VirtualQueryEx, MEMORY_BASIC_INFORMATION, and related constants Sep 19, 2014
@dblock
Copy link
Member

dblock commented Sep 20, 2014

The new VirtualQueryEx method needs a test, please. Also would be nice to squash the commits. Thanks.

@apskii
Copy link
Contributor Author

apskii commented Sep 20, 2014

Oops, I somehow missed the existence of kernel32 tests initially.
Upd: Sorry, this is not correct atm, don't merge.

@apskii
Copy link
Contributor Author

apskii commented Sep 20, 2014

Seems ok now.

@dblock
Copy link
Member

dblock commented Sep 20, 2014

Perfect, thx.

dblock added a commit that referenced this pull request Sep 20, 2014
Added VirtualQueryEx, MEMORY_BASIC_INFORMATION, and related constants
@dblock dblock merged commit 48ff85e into java-native-access:master Sep 20, 2014
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
…-native-access#368)

Motivation:

We should ensure we trigger the event on the right time, which is when the handshake is really complete.

Modifications:

Keep track on when the handshake was done and only notify then

Result:

Correct timing of the event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants